I used %s for the original logs without much thought (copied from some blog post IIRC), and it worked, but for mapping to an actual string, %@ is the way to go, so fixed that (format string reference). We have to strip out the {public} and {private} OSLog specifiers, but then we can get the log message as a regular String to show in the debugger.
Then the new Logging protocol has conformees in OSLog and the new DebugLog so we can transparently switch between them. DebugLog even optionally takes another Logging instance so we can continue to send the OSLog messages in addition to capturing them in the debugger.
The debug logger only starts when the debugger does (and turns off when the floating button is dismissed) for performance reasons.
For an added cherry on top, we can uses DebugLogger in tests to verify the log messages being generated by some failure conditions.
Potentially in the future we could add log filtering and searching, and fancy stuff like that, but I'm not going to worry about it now.
Note that iOS 14+ has a much nicer logging format that doesn't use StaticString, but we can't use it.
I used %s for the original logs without much thought (copied from some blog post IIRC), and it worked, but for mapping to an actual string, %@ is the way to go, so fixed that (format string reference). We have to strip out the
{public}and{private}OSLog specifiers, but then we can get the log message as a regular String to show in the debugger.Then the new
Loggingprotocol has conformees inOSLogand the newDebugLogso we can transparently switch between them.DebugLogeven optionally takes anotherLogginginstance so we can continue to send theOSLogmessages in addition to capturing them in the debugger.The debug logger only starts when the debugger does (and turns off when the floating button is dismissed) for performance reasons.
For an added cherry on top, we can uses
DebugLoggerin tests to verify the log messages being generated by some failure conditions.Potentially in the future we could add log filtering and searching, and fancy stuff like that, but I'm not going to worry about it now.
Note that iOS 14+ has a much nicer logging format that doesn't use StaticString, but we can't use it.