search

appcues / mojito

An easy-to-use Elixir HTTP client, built on the low-level Mint library.
https://hexdocs.pm/mojito/Mojito.html
MIT License
349 stars 34 forks source link

Fragment handling in URI #28

Closed alappe closed 5 years ago

alappe commented 5 years ago

At the moment, an existing fragment of the requested URI is passed down to mint. If I understand it correctly, this should not be the case. I checked with hackney, httpie and other tools and they all omit the fragment.

Clients are not supposed to send URI fragments to servers when they retrieve a document, […] https://en.wikipedia.org/wiki/Fragment_identifier

gamache commented 5 years ago

Hello @alappe! Sorry for the delayed reply, you caught me on vacation. Thank you for this issue and PR -- it will be included in the next release.

alappe commented 5 years ago

Perfect, thanks :-)

gamache commented 5 years ago

Fixed in 0.4.0. Thanks again!