appcues / mojito

An easy-to-use Elixir HTTP client, built on the low-level Mint library.
https://hexdocs.pm/mojito/Mojito.html
MIT License
349 stars 34 forks source link

Doesn't handle Connection:Close Responses #63

Closed bmteller closed 4 years ago

bmteller commented 4 years ago

The single request pool doesn't handle responses with Connection:close.

https://github.com/appcues/mojito/blob/master/lib/mojito/request/single.ex#L39

There is no handling of tcp_closed message so the Mint state machine never receives the close indicator so never knows the response has been fully received. Similar, issue with TLS as well.