appcues / mojito

An easy-to-use Elixir HTTP client, built on the low-level Mint library.
https://hexdocs.pm/mojito/Mojito.html
MIT License
349 stars 34 forks source link

Mint with pool: false leaks HTTP connections like a sieve #82

Closed bmteller closed 3 years ago

bmteller commented 3 years ago

Search for close in Single (https://github.com/appcues/mojito/blob/master/lib/mojito/request/single.ex). There are no calls to Mint.HTTP.close. If the socket is not closed it is leaked until the process dies. see: https://hexdocs.pm/mint/Mint.HTTP.html#close/1

andyleclair commented 3 years ago

Closed in #83