search

appernetic / hugo-nederburg-theme

Nederburg is a fast and secure hugo theme and is a port of the Tracks WP theme
Other
106 stars 86 forks source link

Remediate HTMLProofer findings #59

Closed ayeks closed 5 years ago

ayeks commented 5 years ago

Hi,

thanks a lot for creating the theme! I am in the progress of migrating my Jekyll site to Hugo. When I validated the Hugo generated HTML with the HTMLProofer it found a lot of errors.

Those where for example:

  *  90:105: ERROR: ID menu-item already defined (line 90)
  *  94:105: ERROR: ID menu-item already defined (line 94)
  *  98:105: ERROR: ID menu-item already defined (line 98)
  *  http://fonts.googleapis.com/css?family=Raleway%3A400%2C700&subset=latin%2Clatin-ext&ver=4.7.2 is not an HTTPS link (line 44)
     <link rel="stylesheet" id="ct-tracks-google-fonts-css" href="//fonts.googleapis.com/css?family=Raleway%3A400%2C700&amp;subset=latin%2Clatin-ext&amp;ver=4.7.2" type="text/css" media="all">

I remediated the findings in my commits with no changes to the appearance of the rendered HTML pages.

Best regards Lars

appernetic commented 5 years ago

Thanks for the PR! Merged. I used the original CSS from the WP theme and have not validated it.