appfeel / admob-google-cordova

AdMob ads Cordova/Phonegap/Intel XDK plugin for Android iPhone with latest SDK's
MIT License
132 stars 127 forks source link

Push Notification conflict #97

Open monckey100 opened 6 years ago

monckey100 commented 6 years ago

https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/INSTALLATION.md

According to documentation here this plugin is not using gradle to integrate Google Play Services package, please fix this so I can finally use both push notifications and your admob! If I end up having to fork my own version and integrate gradle, I'll remove the appfeel contribution which I originally had no intention of doing. I desperately need both push notifications and admob and it's surprising to me that the functionality is so hard to integrate cleanly.

sergio-rabinovich commented 6 years ago

I've the same problem. I need both plugins. Did you solve?

Thanks in advance

monckey100 commented 6 years ago

Yes! I ended up using these guys called http://onesignal.com

Works perfectly and has more functionality than this broken plugin. I regret spending so long messing with the different versions of admob + this plugin. Absolute garbage when an official plugin doesn't work properly for its own platform.

sergio-rabinovich commented 6 years ago

I solved, using other admob plugin https://github.com/floatinghotpot/cordova-admob-pro This work find with phonegap-plugin-push and not need to use an external service like onesignal.

Here is my config.xml

<plugin name="phonegap-plugin-push" spec="1.10.5" source="npm">
    <variable name="FCM_VERSION" value="15.0.0" />
    <param name="SENDER_ID" value="XXXXXXX" />
</plugin>

<plugin name="cordova-plugin-admobpro" source="npm">
    <variable name="PLAY_SERVICES_VERSION" value="15.0.0" />
</plugin>

Regards!

monckey100 commented 6 years ago

You'll run into more issues with GPS and phone gap build not being the right version..I'm glad it worked out for you, hopefully they will fix these issues one day. I'm guessing you compile locally?