search

appfeel / node-pushnotifications

Push notifications for GCM, APNS, MPNS, AMZ (automatic detection from device token)
MIT License
541 stars 127 forks source link

Support for Android channel ID? #110

Closed orenkatz-lp closed 5 years ago

orenkatz-lp commented 5 years ago

Hey, Is there any support for setting the Android channel ID in the payload? (android_channel_id)

Thanks, Oren

alex-friedl commented 5 years ago

Hi @orenkatz-lp,

the lib supports all fields of the underlying lib node-gcm.

At first glance it does not appear to support _android_channelid ?

orenkatz-lp commented 5 years ago

Thanks, I was able to make it work by making a change to one of the files. I created a pull request - https://github.com/appfeel/node-pushnotifications/pull/111

alex-friedl commented 5 years ago

Hi @orenkatz-lp, I merged your PR and currently try to write a test for it. Is it really working for you? It does not appear that node-gcm is including android_channel_id in its message payload?

alex-friedl commented 5 years ago

ah my bad, it is part of the inner notification object. Will push the test and release a new version now. Fixed by #111