search

appfeel / node-pushnotifications

Push notifications for GCM, APNS, MPNS, AMZ (automatic detection from device token)
MIT License
534 stars 126 forks source link

Breaking changes in dependecy node apn #17

Closed ryanthegiantlion closed 7 years ago

ryanthegiantlion commented 7 years ago

When trying to send an apple push there is the following error:

TypeError: apn.Connection is not a constructor

This seems to be related to breaking changes in the node-apn package (apn.Connection has been renamed to apn.Provider):

https://github.com/argon/node-apn/blob/develop/doc/whats-new.markdown

The node-apn dependency should be pinned to 1.* until the library accomodates for the changes in v2 of the node apn package.

vedi commented 7 years ago

Experiencing the same issue. I think it's better to constrain all dependency version. Sooner or later we'll got issues with other libraries as well.

appfeel commented 7 years ago

Solved in https://github.com/appfeel/node-pushnotifications/pull/11