search

appfeel / node-pushnotifications

Push notifications for GCM, APNS, MPNS, AMZ (automatic detection from device token)
MIT License
534 stars 125 forks source link

Update typescript definitions #193

Open deivi98 opened 10 months ago

deivi98 commented 10 months ago

Typescript definitions are a bit outdated. Can them be updated please?

https://github.com/appfeel/node-pushnotifications/issues/120

miqmago commented 7 months ago

I've created a new branch that's completely rewritten into typescript. It's a big refactoring and needs some strong review and test, not only myself. I think it can be the next big release for this repo and make it easier to maintain.

@alex-friedl since you've been contributing a lot to this repo, I've sent you a message, maybe we can do some thinking together.

miqmago commented 4 months ago

@vitalyster would be awesome if you could explain little bit your feedback, did you take a look at the branch? Is it crazy? Please let me know how would you like to collaborate!

vitalyster commented 4 months ago

@miqmago I'm pretty sure it is much easier and less error prone to maintain existing type definitions but not to do a complete rewrite which will add zero value but require a lot of work

miqmago commented 4 months ago

@vitalyster thank for your comments. Completely agree on that it is easier to keep code as it is right now. On the other side, in my opinion typescript is becoming the new standard. Also in fact typescript is something that does not require any rewrite, one could change the name of the files and bum! they are in typescript ☺️

The big effort is on the testing area, which is something that anyway needs someone to take a look every once and then.

On the other side, right now the control of type definitions is over this repo which is not really desirable...

Let's see if there is more time available, I'm planning to use this module for long term and it is interesting to do things that are maintainable in a long term vision. The only drawback is that it will not be immediate. Maybe we will have to survive with outdated type definitions except if there is someone who maintains them...