search

appfeel / node-pushnotifications

Push notifications for GCM, APNS, MPNS, AMZ (automatic detection from device token)
MIT License
544 stars 125 forks source link

V2 - Deprecated FCM APIs, add FCM method (HTTP v1 new API) #207

Closed wcalebgray closed 5 months ago

wcalebgray commented 5 months ago

From PR #194 , this copies over the code and fixes the tests (mostly ramda failing)

Exactly none of this has been tested so far.

giantslogik commented 5 months ago

@wcalebgray there an ETA on this or a linked issue?

alex-friedl commented 5 months ago

@wcalebgray @giantslogik If you can confirm that this PR version works with FCM, I'd be happy to take a closer look and merge and release it

giantslogik commented 5 months ago

@alex-friedl @wcalebgray I'll try and test the PR for my usecase. I've also created https://github.com/appfeel/node-pushnotifications/issues/208 to keep users informed of the issue / resolution.

wcalebgray commented 5 months ago

I've tested this manually and it appears to work for FCM, but I have not completely tested all other uses to make sure nothing else broke. Would very much welcome other testing.

alex-friedl commented 5 months ago

Merging this in order to fix linter and doc issues and prepare a release

giantslogik commented 5 months ago

@alex-friedl how are the typescript definitions maintained ? I'm using @types/node-pushnotifications , and don't see the FCM API there. cc: @wcalebgray

alex-friedl commented 5 months ago

They are maintained separately in that package, yes. However I am not maintaining these. I assume they will catch up eventually but feel free to make a PR there, it would be greatly appreciated :)