search

appfeel / node-pushnotifications

Push notifications for GCM, APNS, MPNS, AMZ (automatic detection from device token)
MIT License
534 stars 126 forks source link

priority param different for Google and IOS #36

Closed reijosirila closed 7 years ago

reijosirila commented 7 years ago

GCM expects string, but APN expects integer. How to define prioroties for both ?

alex-friedl commented 7 years ago

Good point @reijosirila.

I looked into the current documentations and it looks like both GCM and APN basically have two different priorities. GCM calls them normal and high whereas APN uses 5 and 10.

@appfeel: We should probably have the API accept high and normal as values and translate this for APN to the respective integer values? What do you think?

appfeel commented 7 years ago

@alex-friedl yes, that would be the solution.

@reijosirila @alex-friedl are you available to implement? Otherwise I'll try to dedicate time during next 2 weeks.

alex-friedl commented 7 years ago

@appfeel: I could try to implement it this weekend.

alex-friedl commented 7 years ago

@appfeel, @reijosirila https://github.com/appfeel/node-pushnotifications/pull/39 Hope this is what you are looking for

reijosirila commented 7 years ago

Looks good. Thanks 👍

appfeel commented 7 years ago

https://github.com/appfeel/node-pushnotifications/pull/39