search

appfeel / node-pushnotifications

Push notifications for GCM, APNS, MPNS, AMZ (automatic detection from device token)
MIT License
534 stars 126 forks source link

Wrong callback behavior. #7

Closed r0b1n closed 7 years ago

r0b1n commented 8 years ago

For iOS: This always goes to first parameter which means error: https://github.com/appfeel/node-pushnotifications/blob/master/lib/push-notifications.js#L118-L123 Even if it is completed.

Also documentation is wrong, send callback should contain error and result parameters.

miqmago commented 8 years ago

I see the problem. I'm just completly refactoring to provide better error handling and api. I will provide feedback soon.

vedi commented 7 years ago

I used such workaround to solve this: https://github.com/vedi/node-pushnotifications/commit/1dae83d2ded453469e9ddc23d5fff2ae6917c655

appfeel commented 7 years ago

Fixed in https://github.com/appfeel/node-pushnotifications/pull/11, thanks