search

appfolio / ae_page_objects

Page Objects for Capybara
MIT License
28 stars 9 forks source link

ll - ApplicationRouter throws exception when the path isn't resolvable #164

Closed leoskyrocker closed 3 years ago

leoskyrocker commented 8 years ago

Previously, the code raises an exception for calling a method on a nil object when a path specified in the AePageObject::Document is not resolvable.

This is confusing to the consumer because:

  1. in the stacktrace, it doesn't complain at the line the causes the problem.
  2. the error message itself isn't the root cause of the problem.

To reproduce this issue, refer to the Github issue https://github.com/appfolio/ae_page_objects/issues/163

dtognazzini commented 8 years ago

Thanks for the fix! Seems like an improvement. I have a few questions.

leoskyrocker commented 3 years ago

@spjsschl Hi Appfolians, I don't think I can recall the context for this anymore, and so I won't be able to move this forward. So I'm going to close this PR. Happy 2021 :)