search

appfolio / ae_page_objects

Page Objects for Capybara
MIT License
28 stars 9 forks source link

AePageObjects::Collection specifies 'exact: true' when query #188

Open JingyuZ opened 8 years ago

JingyuZ commented 8 years ago

We didn't specify exact: true at any other places except for Collection class. For all the others they just use the default value for Capybara setting, which is false. https://github.com/appfolio/ae_page_objects/blob/master/lib/ae_page_objects/elements/collection.rb#L71

We are not sure why Collection is the exceptional one that has to specify exact: true. Any reasons behind it? If not, could we remove it and use the default value?

ipmsteven commented 8 years ago

Hi @JingyuZ Does this cause problem in running test? could you give more context?

JingyuZ commented 8 years ago

I created the issue not because I want to remove exact: true from collection right now, it’s more like a question for Donnie why we are only being strict with collections, why don't we set exact: true in Capybara settings and make everything strict?