appfolio / ae_page_objects

Page Objects for Capybara
MIT License
28 stars 9 forks source link

Support Ruby 3 #216

Closed sarahsehr closed 1 year ago

sarahsehr commented 1 year ago
sarahsehr commented 1 year ago

Evaluate state of ae_page_objects for Ruby 3 compatibility

dtoms commented 1 year ago

What are the coverage metrics from Simplcov?

dtoms commented 1 year ago

I believe one of the main concerns from @Diasporism was that the Ruby3 parameters changes might mean tests pass incorrectly. I don't see anything specifically addressing that here (not complaining). Do we still think that might be a valid issue?

sarahsehr commented 1 year ago

What are the coverage metrics from Simplcov?

Are you asking for the numbers or what it does?

sarahsehr commented 1 year ago

I believe one of the main concerns from @Diasporism was that the Ruby3 parameters changes might mean tests pass incorrectly. I don't see anything specifically addressing that here (not complaining). Do we still think that might be a valid issue?

I'm waiting to hear back from @Diasporism of an example test that passed when it should have failed. Based on my understanding of the gem (I've been a consumer for a long time, even if not an expert on the gem), that shouldn't happen.

dtoms commented 1 year ago

@sarahsehr the coverage numbers.

sarahsehr commented 1 year ago

@sarahsehr the coverage numbers.

The unit test coverage was ~41%. I looked through the actual files and all the "covered" lines were just the class and method names, not the bodies. Elvis Restly had removed the integration tests, but I added them back because of that low coverage.

sarahsehr commented 1 year ago

All PropertyApp selenium tests are passing against a reference to this branch. Nothing to directly QA.