appfolio / ae_page_objects

Page Objects for Capybara
MIT License
28 stars 9 forks source link

fix Routing incorrectly matches documents issue and fix for #63 #73

Closed ipmsteven closed 10 years ago

dtognazzini commented 10 years ago

This fix is dependent on the order of the parameters to window.change_to and the order of the routes yielded to the internal blocks in recognizes?

Here's a failing test that highlights the parameter order issue. This test needs to pass.

Another test should be written to the order in which routes are yielded.

dtognazzini commented 10 years ago

After some more reading and experimentation, I see how these changes address the issue. As we discussed via chat, please add comments documenting the "why" of your changes and add a test case covering all the permutations. Thanks!

dtognazzini commented 10 years ago

Addresses issue #63