Set `therubyracer` as a development dependency

appfolio / eslint-rails

MIT License

39 stars 22 forks source link

Set `therubyracer` as a development dependency #19

Closed zachahn closed 8 years ago

zachahn commented 8 years ago

Execjs should handle the presence of a Javascript runtime, whether it's Node, therubyracer, or something else. Specifically requiring this dependency unnecessarily makes this gem heavier

e0da commented 8 years ago

@zachahn That sounds right to me. Thank you!

@jonkessler, do you have any thoughts?

jonkessler commented 8 years ago

Fair point. 👍

e0da commented 8 years ago

@zachahn I went ahead and released 1.0.1 with your fix included. Thank you for contributing!

zachahn commented 8 years ago

Awesome, thanks all!