Lint all files - Githubissues

appfolio / eslint-rails

MIT License

39 stars 22 forks source link

Lint all files #22

Closed dkniffin closed 8 years ago

dkniffin commented 8 years ago

This PR adds the following functionality:

The default run (rake eslint:run) now lints all JS asset files (Related to #20)
If you pass an argument, it can be either a file or a directory, and it can be relative to the project root, or the asset root. (Kinda makes #15 obsolete)
There is now a progress bar with the severity of linting errors in each file (similar to rubocop)
The output table displays the source filename (#20)
Updates the readme to reflect the changes

dkniffin commented 8 years ago

@jonkessler I just wanna make sure you're aware of this PR as well. With this, #15 is kind of unnecessary.

dkniffin commented 8 years ago

Oh, I did not test this with the web interface, because it actually doesn't work in my app, but it should still work, I think.

dkniffin commented 8 years ago

Once this gets reviewed and merged, I've got another branch ready to go, which adds the ability to use eslint plugins. Unfortunately, it's kinda based on this PR, so this one will have to be merged first.

e0da commented 8 years ago

This is pretty exciting to watch. Thanks @dkniffin! And of course thanks @jonkessler for keeping it alive!

dkniffin commented 8 years ago

Alright, I've pushed up some more changes, and rebased. Let me know if there's anything else I should do for this.

jonkessler commented 8 years ago

Looks good.. let me do a little manual testing, and then I'll merge as soon as I can. Thanks.

jonkessler commented 8 years ago

@dkniffin Would you mind adding a description to the eslint:run_all task so that it shows up in rake -T?

dkniffin commented 8 years ago

@jonkessler done.