search

appfolio / eslint-rails

MIT License
39 stars 22 forks source link

Add support for eslint plugins #23

Closed dkniffin closed 8 years ago

dkniffin commented 8 years ago

This PR adds the ability to use eslint plugins. Currently, the only one included is the react plugin, but I've written it in a way that it should be easy to add any others that we want to support.

Unfortunately, I couldn't think of a good way to import the plugins from github at runtime, so the minified plugin source must be included in the gem. So, I've also written a little shell script that can be used to download, minify, and include a given list of plugins.

I haven't updated the readme to reflect these changes yet. Let me know if you want me to do that, and what I should include.

dkniffin commented 8 years ago

@jonkessler Any chance of getting this reviewed and merged soon?

jonkessler commented 8 years ago

Yes, I've been pretty busy, sorry. I'll take a look soon.

dkniffin commented 8 years ago

👍 Thanks!

dkniffin commented 8 years ago

Alright, I made the requested changes. Let me know if you want me to change anything else.

dkniffin commented 8 years ago

Alright, that's fixed. Sorry about that.

jonkessler commented 8 years ago

No worries. Thanks for fixing!

jonkessler commented 8 years ago

Released version 1.2.0. Thanks again!