search

appfolio / eslint-rails

MIT License
39 stars 22 forks source link

Add compatibility with Ruby 2.0 #32

Closed bbonamin closed 7 years ago

bbonamin commented 7 years ago

First of all, let me express my gratitude for this gem.

I've been trying to add a javascript linter to a project I'm working on so we can have some standards, and by far eslint-rails has been the best suited.

Now, for this project, we need compatibility with Ruby 2.0 (yeah yeah, I know it's not receiving fixes or patches anymore, but we can't upgrade yet.)

The gemspec of eslint-rails doesn't specify a minimum ruby version, but if you try to use the gem with < 2.1, it breaks because of the required keyword arguments that were introduced in 2.1.

This minor change makes the gem compatible with Ruby 2.0 and ensures it's specified on the gemspec.

Thanks!

jonkessler commented 7 years ago

Left one comment. Just curious.. what issues are preventing you from upgrading from 2.0? I don't recall any serious issues when we upgraded our main app, which is many hundreds of thousands of lines of code.

bbonamin commented 7 years ago

We don't really have any specific issues that prevent upgrading other than allocating the resources for a few dozen ruby applications. I've used newer rubies in other projects without issues either, just improvements!

Thanks.

jonkessler commented 7 years ago

For sure. Definitely worthwhile for the performance improvements in our experience. Thanks for the pull!