search

appfolio / react-gears

AppFolio component library for React & Bootstrap
https://appfolio.github.io/react-gears
BSD 2-Clause "Simplified" License
17 stars 9 forks source link

Considering shift from `react-select-plus` to `react-select v2` #512

Open moyuanhuang opened 5 years ago

moyuanhuang commented 5 years ago

This issue is based on the assumption that we're only using react-select-plus instead of react-select. Correct me if I'm wrong, and I'll close the issue :)

The purpose of using react-select-plus was to support option groups in the dropdown, a feature that react-select didn't have.

Now that the v2 version of react-select added support this feature (I think they just back merged the code from react-select-plus), react-select-plus is not longer 'actively maintained'. We should consider changing the package from react-select-plus to react-select for the sake of compatibility. It's good also because react-select v2 now support a lot of new features that could probably enable us to do more interesting things! https://react-select.com/home

gthomas-appfolio commented 5 years ago

Hi @moyuan, thanks we should do that, there were just some styling changes (border, etc) that we’d need to rework to be themeable.
Current open PR is tracked here: #461

phwebi commented 4 years ago

Replace react-select-plus with react-select 2.0

moyuanhuang commented 4 years ago

@phwebi Do we have any plans on this? I've got a working branch

phwebi commented 4 years ago

@moyuanhuang I saw this issue when I was browsing yesterday and I think it'd be nice to do! Feel free to make a PR if your branch is up to date and I can help review 😄