Fix package naming and make sure hub is ready to use when started

chaitanyachavali commented 2 years ago

Root package in ranger server bundle seems to be incorrect, fixed it.
Moved from io.appform.ranger.zk.server.bundle to io.appform.ranger.server.bundle

Added a check with retryer which checks if ServiceFinder exists for each Service
Also checking if initialRefreshCompleted within each ServiceFinder.serviceRegistry
Moved initialRefreshCompleted from ServiceRegistryUpdater into ServiceRegistry because we have multiple services being refreshed together
Why adding the check in ServiceFinderHub#start rather than to RangerServerBundle.run or maybe as a refresher signal? Wanted to enforce this check as we would guarantee that hub is ready for use as it get started and with refresher or other choices it may go away as there can be other custom clients that can be made and replaced.
Why not have the check in the ServiceFinderHub#updateRegistry ? This is getting executed asynchronously via monitor method, need to have blocking call till everything is get's ready.

koushikr commented 2 years ago

@santanusinha : Can you please review the above? I have proposed 'em changes, so don't want to merge it myself, that would be counterproductive :)

santanusinha commented 2 years ago

I have reviewed LGTM ..

chaitanyachavali commented 2 years ago

@santanusinha Can you please merge and release these changes?

appform-io / ranger