search

appgate / sdp-api-client-go

Golang client for the appgate SDP API
MIT License
2 stars 1 forks source link

v13 OpenAPI LicenseUsersDistinguishedNameDelete #3

Closed joshhuie closed 3 years ago

joshhuie commented 3 years ago

Hello! I've encountered an error when executing a LicenseUsersDistinguishedNameDelete in api_licensed_users.go. I get a 404 Not Found error when passing a correctly formatted distinguished name to this function. I suspect the query is being URL encoded incorrectly.

dlnilsson commented 3 years ago

hey @joshhuie , I've not been able to reproduce this, you can see my test here https://gist.github.com/danijeel/cf11720e432216b426bdf3fe22710d20

tested with 5.2.2-22233-release using v13 and 5.3.2-23587-release using v13

What version on the appliances are you using?

stephengroat commented 3 years ago

👋 currently using 5.2.3-22549-release (c)

joshhuie commented 3 years ago

👋 currently using 5.2.3-22549-release (c)

@danijeel

dlnilsson commented 3 years ago

I cant see any major diff between the two minor versions that would affect this, Do you get the same error from the gist above with your given input? btw, i can give you an head's up that in 5.4 this endpoint has been removed.

stephengroat commented 3 years ago

@danijeel what endpoint is replacing it? we rely on this for critical functionality

joshhuie commented 3 years ago

I cant see any major diff between the two minor versions that would affect this, Do you get the same error from the gist above with your given input?

Yup, I still get a error 404 Not Found. The encoded URL shows up as this DELETE /admin/license/users/CN%3Dexample%40testing.email%2COU%3DLogin+With+Google HTTP/1.1 for this distinguished name: Delete DN "CN=example@testing.email,OU=Login With Google"

gokhan-berberoglu commented 3 years ago

@joshhuie thanks for the info, we're investigating.

@stephengroat

@danijeel what endpoint is replacing it? we rely on this for critical functionality

Appgate SDP introduces changes to licensing with v5.4. Starting with v5.4, Controller automatically cleans up the inactive user licenses after lease period, 30 days. It will not be possible to delete assigned licenses manually, so rest api is dropped. If you contact Support with information on why deleting license assigment via rest api is critical for you, we can discuss various options.

dlnilsson commented 3 years ago

After digging through the changelog in the openapi-generator, we can see that this issue has been resolved upstream, I'll see if I can generate a new one. This proberbly affect all versions.

dlnilsson commented 3 years ago

This is fixed in 1.0.1 https://github.com/appgate/sdp-api-client-go/releases/tag/v1.0.1, this includes v13 re-generated with openapitools/openapi-generator:cli-v5.1.0 that resolves this issue with url encoding.