search

appgate / terraform-provider-appgatesdp

Terraform Provider for Appgate SDP
https://registry.terraform.io/providers/appgate/appgatesdp
MIT License
21 stars 10 forks source link

Incorrect seed version #93

Closed hobietje closed 3 years ago

hobietje commented 3 years ago

The seed files generated by the "appgate_appliance_seed" data source are not accepted by our cz-config. Regardless of the "latest_version" flag, we seem to get version 13 provided by the TF provider. We receive the error "WARNING [seeding] Invalid seed config: Invalid seed configuration, expected Optional[Remote] at remote but got dict..." when trying to use them as the seed.

A manually exported seed file using the "latest_version" flag works fine, and provides a version 14 seed file.

hobietje commented 3 years ago

Based on a quick review of the TF provider code, my guess is that:

The version const is set in https://github.com/appgate/terraform-provider-appgate-sdp/blob/b74b7107c71b46d133206e4088c3c1090cb8f949/appgate/config.go#L18 This is later provided as a HTTP Accept header in https://github.com/appgate/terraform-provider-appgate-sdp/blob/b74b7107c71b46d133206e4088c3c1090cb8f949/appgate/config.go#L63 This seems to drive the version of the seed that is provided back? If my guess is true, it would be good to change this from a const to a Config that we can set in our TF provider.

dlnilsson commented 3 years ago

Hi, What versions are you using for

hobietje commented 3 years ago

Hi @danijeel

appliances are the AWS BYOL AMI: 5.3.2-23587-release terraform-provider-appgate-sdp: 0.3.5 terraform: v0.14.4

dlnilsson commented 3 years ago

I can confirm this issue @hobietje, it will be resolved in the upcoming release.