search

appinioGmbH / flutter_packages

Dart and Flutter plugins/packages used and maintained by @appinioGmbH
193 stars 224 forks source link

Calling instagram share, during exception it will return successful message of "ERROR" #103

Closed RobertBrunhage closed 1 year ago

RobertBrunhage commented 1 year ago

https://github.com/appinioGmbH/flutter_packages/blob/526aa7735e1f0bd181b2e0869de3d88025b8bb49/packages/appinio_social_share/android/src/main/java/com/appinio/socialshare/appinio_social_share/utils/SocialShareUtil.java#L175

To reproduce just send an image from await getTemporaryDirectory and when it fails, it doesn't throw an exception but instead it will return a message saying "ERROR".

I suggest logging and throwing so when we get an issue it doesn't fail silently.