appinioGmbH / flutter_packages

Dart and Flutter plugins/packages used and maintained by @appinioGmbH
187 stars 214 forks source link

CustomVideoPlayer is not compatible with Dismissible #205

Closed Z6P0 closed 9 months ago

Z6P0 commented 9 months ago

Plugin name

appinio_video_player

Describe the bug

CustomVideoPlayer is not compatible with Dismissible

To Reproduce

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Dismissible(
        key: UniqueKey(),
        direction: DismissDirection.vertical,
        child: Center(child: CustomVideoPlayer(customVideoPlayerController: customVideoPlayerController)),
        onDismissed: (direction) {
          Navigator.pop(context);
        },
      ),
    );
  }

Expected behavior

The player should be dismissed with swipe gesture.

khanmujeeb687 commented 9 months ago
          key: UniqueKey(),
          direction: DismissDirection.horizontal,
          child: Center(
            child: CustomVideoPlayer(
              customVideoPlayerController: _customVideoPlayerController,
            ),
          ),
          onDismissed: (direction) {
            _customVideoPlayerController.dispose();
          },
        )
    Hey @Z6P0 , Thanks for reporting the issue. you can dispose the controller on onDismissed and it should work.