appinioGmbH / flutter_packages

Dart and Flutter plugins/packages used and maintained by @appinioGmbH
187 stars 214 forks source link

[Issue #26] Adding flag for horizontal and vertical swiping #37

Closed mlabisi closed 1 year ago

mlabisi commented 1 year ago

Addresses / Fixes #26

This PR adds two flags, horizontalSwipeEnabled and verticalSwipeEnabled!

mlabisi commented 1 year ago

Sorry about the spacing/formatting changes! My IDE automatically added them. Let me know if I should revert those.

M-S-KHAN commented 1 year ago

Much required. Please approve the PR @bilalhamud

simplenotezy commented 1 year ago

Thanks for the PR @mlabisi - would love to get that in! 😊

phongnd93 commented 1 year ago

Thanks for the PR @mlabisi - hope this PR is released soon 😊

Alii-isk commented 1 year ago

Thanks for the PR @mlabisi - would love to get that in! 😊

vvanan158 commented 1 year ago
  void _onEndAnimation() {
    if ((_left < -widget.threshold || _left > widget.threshold) &&
        widget.horizontalSwipeEnabled) {
      _swipeHorizontal(context);
    } else if ((_top < -widget.threshold || _top > widget.threshold) &&
        widget.verticalSwipeEnabled) {
      _swipeVertical(context);
    } else {
      _goBack(context);
    }
  }

Thanks, it work for me :)

clarson15 commented 1 year ago

any update on this?

mlabisi commented 1 year ago

I’ll need approval from the repo owner in order for this PR to be merged 😅On Jan 29, 2023, at 7:08 PM, Charles Larson @.***> wrote: any update on this?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

bilalhamud commented 1 year ago

Implemented among other features with version 2.0.0