appirio-tech / accounts-app

accounts.topcoder.com
2 stars 25 forks source link

Same message being shown for sso and non sso users after registration #133

Closed vikasrohit closed 7 years ago

vikasrohit commented 7 years ago

Same message Thanks for joining Topcoder. is being rendered for both sso and non sso users after successful registration.

vikasrohit commented 7 years ago

@ajefts fyi

vikasrohit commented 7 years ago

Fixed in https://github.com/appirio-tech/accounts-app/tree/hotfix/same-msg-for-sso-non-sso-register

ajefts commented 7 years ago

@vikasrohit Looks like the page is blank still...at least for SSO reg success...

vikasrohit commented 7 years ago

Ohk. Let me reproduce it by following full flow.

vikasrohit commented 7 years ago

It was not reproducible on on local, but could reproduce it on dev. Seems link inline controllers in state configuration for ui-router were causing the troubles. Fixed now. Tested in dev (accounts-test.topcoder-dev.com)

vikasrohit commented 7 years ago

Closing to clean up.