search

appirio-tech / accounts-app

accounts.topcoder.com
2 stars 25 forks source link

Error state of form elements is not visible #151

Closed vikasrohit closed 7 years ago

vikasrohit commented 7 years ago
screen shot 2017-08-02 at 12 42 28 pm

fyi @fnisen @vic-topcoder

vikasrohit commented 7 years ago

Done. @fnisen I haven't added error class to the password field because it was giving me wrong UX as a user. We are showing validation errors(or status) in tooltip for password field, so I guess we can avoid adding error class for password field. However, if you still think it would be good to have error class on password field, I can add it.

fnisen commented 7 years ago

Thanks @vikasrohit. Yes, this is the right approach--we don't need the error class on password field because the user should never end up in an error state; the validation is already showing them that they haven't filled out the form as needed.