search

appirio-tech / accounts-app

accounts.topcoder.com
2 stars 25 forks source link

Show password button is misplaced on member side reset password page #164

Closed vikasrohit closed 7 years ago

vikasrohit commented 7 years ago
screen shot 2017-08-28 at 2 38 49 pm
vikasrohit commented 7 years ago

Fixed. Should be in dev by EOD.

fyi, @fnisen

fnisen commented 7 years ago

@vikasrohit I couldn't test this in Dev. When I clicked on this link: https://accounts.topcoder-dev.com/member/reset-password?token=R87jKT&handle=beta_35, it redirected me here: https://accounts.topcoder-dev.com/member/reset-password. If it's fixed, I'll take your word for it.

vikasrohit commented 7 years ago

@fnisen It seems like we have some problem with cloud distribution for routing. If we use https://accounts.topcoder-dev.com/#!/member/reset-password?token=R87jKT&handle=beta_35 it works. It seems we have the same problem which had earlier which @mtwomey fixed. @mtwomey Can you please help us here again?

fnisen commented 7 years ago

Have pinged Matt on Slack to ask him to check it out.

mtwomey commented 7 years ago

@vikasrohit - I dont think this issue (see ^^^) with redirect is the same as last time (a cloud front configuration issue). I think it's something in the dev branch over the past couple of weeks (relating to the 301 redirect that happens). Could you please take a look?

fnisen commented 7 years ago

@vikasrohit looks like it's working now. I tested again just now and it worked correctly on both the member and connect sides, using incognito.

vikasrohit commented 7 years ago

Strange. What is making it behave like that. Anyway, if it is working fine now, it is good. Should we move changes to production?

fnisen commented 7 years ago

Yes, please go ahead.

vikasrohit commented 7 years ago

Verified on production. Closing.