appirio-tech / accounts-app

accounts.topcoder.com
2 stars 25 forks source link

MSFT-68 community app issue-2782 #232

Closed sumitdaga closed 5 years ago

nkumar-topcoder commented 5 years ago

@asadath1395 app/views/tc/login.jade file is having conflict with issue #223 and This has already pushed to prod and it's passed in Prod QA. Please take latest login.jade from master branch and merge current issue code in your local, test and PR to qa-accessibility. so that both issue #223 and #232 are in sync.

sumitdaga commented 5 years ago

@veshu @mishacucicea @asadath1395 i just saw the merge conflict and i think now this fix is not even required. With this fix the screen reader will read the social login labels one extra time

nkumar-topcoder commented 5 years ago

Closing this issue as it's already fixed