search

appirio-tech / accounts-app

accounts.topcoder.com
2 stars 25 forks source link

MSFT-88 #243

Closed r0hit-gupta closed 5 years ago

r0hit-gupta commented 5 years ago

changes for https://github.com/topcoder-platform/community-app/issues/2798

mishacucicea commented 5 years ago

@r0hit-gupta Were this items fixed as part of other branches? As you have only one small file changed, it can't fix all these issues. You can't claim you fixed something if it's not part of your branches/changes.

r0hit-gupta commented 5 years ago

@mishacucicea all those issues had the same solution. So, as I went through the issues, I realised this and referenced them under the same PR. This PR fixes all of the issues.

mishacucicea commented 5 years ago

@r0hit-gupta Please reference the solution from existing fixes for each issue.

r0hit-gupta commented 5 years ago

@mishacucicea I have already referenced the PR from each individual issue.

mishacucicea commented 5 years ago

topcoder-platform/community-app#2798 - not working, it's expected that the color changes when using the tab key, which means on :focus topcoder-platform/community-app#2800, topcoder-platform/community-app#2875 - not working, I don't see any highlight when using tab key.

mishacucicea commented 5 years ago

@r0hit-gupta Did you put all needed file changes in this PR? Perhaps you missed some.

r0hit-gupta commented 5 years ago

@mishacucicea I updated the code to change color on tab key for privacy policy. For other issues, is there any particular element for which the highlight is not visible? Because the fix is working fine for me.

mishacucicea commented 5 years ago

@r0hit-gupta The issue you're fixing is https://github.com/topcoder-platform/community-app/issues/2798. The other issues are not fixed by this PR (If something doesn't work, I need to revert the PR, and in this case I can see it's related and fixing only one issue).

Please unlink the other issues.

r0hit-gupta commented 5 years ago

@mishacucicea I have unlinked other issues. Will create a separate PR for them. Please review.

r0hit-gupta commented 5 years ago

@mishacucicea done. Please review.