search

appirio-tech / accounts-app

accounts.topcoder.com
2 stars 25 forks source link

Register username, email, password tooltip. #256

Closed afrisalyp closed 5 years ago

afrisalyp commented 5 years ago

https://github.com/topcoder-platform/community-app/issues/2813 https://github.com/topcoder-platform/community-app/issues/2827

anonymousjaggu commented 5 years ago

@asadath1395 please resolve the conficts

afrisalyp commented 5 years ago

@anonymousjaggu Done.

afrisalyp commented 5 years ago

topcoder-platform/community-app#2813: For some reason, when you move to email after listening to the email, it will say again the tooltip for username as well, same if you go on password.

Still investigating. The problem only appears on Chrome. There is a weird behaviour causes it.

topcoder-platform/community-app#2827: The special characters are not read by NVDA screen reader. Seems to work with JAWS

I think we don't have control to fix it. NVDA doesn't read the character but JAWS read them. How should we handle it?

afrisalyp commented 5 years ago

@mishacucicea Fixed for

topcoder-platform/community-app#2813: For some reason, when you move to email after listening to the email, it will say again the tooltip for username as well, same if you go on password.

mishacucicea commented 5 years ago

Good work! If Jaws reads them, it's OK for now.

nkumar-topcoder commented 5 years ago

@mishacucicea can you pls check. reviewer/QA is having different outcomes, hence on-hold

mishacucicea commented 5 years ago

@nkumar-topcoder Was this merged on dev/prod?

nkumar-topcoder commented 5 years ago

@nkumar-topcoder Was this merged on dev/prod?

@afrisalyp @crazyk07 no this isn't merged, because drasticdpk (deepak) review comment. https://github.com/topcoder-platform/community-app/issues/2813#issuecomment-516762806

@mishacucicea Can you please review this again and let me know.