search

appirio-tech / accounts-app

accounts.topcoder.com
2 stars 25 forks source link

Register page region. #257

Closed afrisalyp closed 5 years ago

afrisalyp commented 5 years ago

https://github.com/topcoder-platform/community-app/issues/2866

afrisalyp commented 5 years ago

Correlated work with https://github.com/topcoder-platform/community-app/issues/2897. Commit added.

mishacucicea commented 5 years ago

@afrisalyp Please don't commit space/tab changes, it's hard to follow the actual code change, also this leads to more conflicts. Remove the introduced spaces and resolve the conflict.

afrisalyp commented 5 years ago

@mishacucicea Thanks for the review. Resolving the conflict.

I'll remove the space as much as possible but for these changes, we need to insert a div as a parent of the form region. https://github.com/appirio-tech/accounts-app/pull/257/files#diff-7b4625c50ae32579225e8ffd2be3b00eR7

Therefore, we need to adjust all the elements inside the new div. We have to do it since jade uses whitespace and indentation as a part of the syntax.

afrisalyp commented 5 years ago

@mishacucicea done.