Closed romitgit closed 5 years ago
can't compile your branch
ERROR in ./~/css-loader!./~/sass-loader!./app/styles/tc/register.scss Module build failed: outline: 2px solid $tc-dark-blue-70; ^ Undefined variable: "$tc-dark-blue-70". in /Users/sexta13/projects/topcoder/accounts-app/app/styles/tc/register.scss (line 50, column 26)
I believe you are missing this import at the top of register.scss @import "../tc-ui-variables";
@sexta13 Fixed now. Please review again. Thanks
@romitgit , please fix the conflicts.
@romitgit , this still is not well done. SSO links are not selectable by tab.
also check this PR https://github.com/appirio-tech/accounts-app/pull/281/files It puts the tabindex to navigate between the sso_links
@sexta13 Fixed changes.
This already appears corrected in production?
But It wasn't there already.
Closing PR as it's already in prod
Fixes https://github.com/topcoder-platform/community-app/issues/2860