search

appirio-tech / accounts-app

accounts.topcoder.com
2 stars 25 forks source link

MSFT-194-Issue-2860 - added focus to interactive elements #265

Closed romitgit closed 5 years ago

romitgit commented 5 years ago

Fixes https://github.com/topcoder-platform/community-app/issues/2860

sexta13 commented 5 years ago

can't compile your branch ERROR in ./~/css-loader!./~/sass-loader!./app/styles/tc/register.scss Module build failed: outline: 2px solid $tc-dark-blue-70; ^ Undefined variable: "$tc-dark-blue-70". in /Users/sexta13/projects/topcoder/accounts-app/app/styles/tc/register.scss (line 50, column 26)

I believe you are missing this import at the top of register.scss @import "../tc-ui-variables";

romitgit commented 5 years ago

@sexta13 Fixed now. Please review again. Thanks

sexta13 commented 5 years ago

@romitgit , please fix the conflicts.

sexta13 commented 5 years ago

@romitgit , this still is not well done. SSO links are not selectable by tab.

sexta13 commented 5 years ago

also check this PR https://github.com/appirio-tech/accounts-app/pull/281/files It puts the tabindex to navigate between the sso_links

romitgit commented 5 years ago

@sexta13 Fixed changes.

mtwomey commented 5 years ago

This already appears corrected in production?

romitgit commented 5 years ago

But It wasn't there already.

nkumar-topcoder commented 5 years ago

Closing PR as it's already in prod