search

appirio-tech / connect-app

Build your next project on Connect with the power of crowdsourcing
https://connect.topcoder.com
44 stars 140 forks source link

Upgrade to latest react (16.8 with hooks) and fix console errors and update deprecated methods to match to best practices #1564

Open vic-tian opened 6 years ago

vic-tian commented 6 years ago

We should update to latest react (16.2 as of Dec 27). There are still issues with our components throwing either warnings or errors. Use React Dev tools to view all warnings and better debug the code.

screen shot 12 screen shot 13

aretheregods commented 6 years ago

Oh, wait, never mind. I had a re-read of the bug bash rules. I'm working on fixes now.

aretheregods commented 6 years ago

@gondzo The solving of this issue seems directly tied to the solving of issue #1424 due to the fact that both of these issues tie to the incompatibility of appirio-tech/react-components in its current form with React v16 and the continuing and deepening tech-debt present in that repo. The errors I'm getting on compiling connect-app are coming from usage of that module. It seems that in order to update this issue, one would have to also fix issue #1424, which is untenable for me at this time given the complexity and depth of both issues. Noting these facts, I'm relinquishing my assignment and opening this issue back up for pickup. All the best to whoever picks this up after me. And good luck.

gondzo commented 6 years ago

we have solved a lot of those errors, but couldn't do this one in parallel with other major upgrades like #1629

vic-tian commented 6 years ago

Latest React is 16.4.1 already... https://github.com/facebook/react/releases

vikasrohit commented 6 years ago

I think we should avoid this for the current release as we are already doing heavy lifting in this release and don't want to get confused which change caused the issue.

RishiRajSahu commented 6 years ago

@gondzo skip this from the challenge you are going to run for CF 9 fixes