[$20] Align design links correctly for design related milestones

appirio-tech / connect-app

Build your next project on Connect with the power of crowdsourcing

https://connect.topcoder.com

44 stars 139 forks source link

[$20] Align design links correctly for design related milestones #2482

Closed RishiRajSahu closed 6 years ago

RishiRajSahu commented 6 years ago

Design links URL should be aligned to the right and 30px from the widest text element design link name. Right now the checkpoint and final design links URL are not uniform (they should).

screen shot 2018-09-07 at 3 23 44 pm

Continued from - https://github.com/appirio-tech/connect-app/issues/2301

Aha! Link: https://topcoder.aha.io/features/TCCONNECT-455

Gauravseta commented 6 years ago

@maxceem any tentative date/time when challenge will start? also how can simran assign it to itself while it is not open for pickup? can you please see into it @gondzo

maxceem commented 6 years ago

@Gauravseta it has to start in several hours, but there is one blocker to be resolved first.

@simranb86 please, don't pick up issues yet, as it's not marked as OPEN FOR PICK UP yet.

But I've learned the lesson. Will remove prices until the challenge is started.

Gauravseta commented 6 years ago

@maxceem there are very few people like simran . else it is never an issue to mark the prices it title. can you please unassign simran if possible? as someoneelse or myself should get equal chance of grabbing this issue. thanks

maxceem commented 6 years ago

@Gauravseta sure

@simranb86 I have to unassign you from the issue so far to keep it fair for all the participants. Please, grab only the issues marked as OPEN FOR PICK UP. I'll let you know as soon challenge started and issues are ready for pick up. I'm still happy that you are interested to participate :-)

maxceem commented 6 years ago

@Gauravseta, @simranb86 just want to let you know that challenge is planned to be started on Monday. The Bug Bash process will be slightly changed.

Gauravseta commented 6 years ago

@maxceem thanks for update. m waiting since 3 hrs.

srjr19 commented 6 years ago

@maxceem Thanks for the update. I picked up because i was enrolled in bug bash already and saw the new tickets come up with pricing on them. Next time i will look for OPEN FOR PICKUP tag too.

Will register for new one when it opens. Thanks

maxceem commented 6 years ago

@Gauravseta, @simranb86 The challenge is on. Important! There is a change in the Bug Bash process, please read the new rules in the challenge spec carefully, before starting work on issue https://www.topcoder.com/challenges/30070926/?type=develop&noncache=true Thank you!

iversonLv commented 6 years ago

Please assign this to me

iversonLv commented 6 years ago

Could I know what password/username to login?

Thanks.

maxceem commented 6 years ago

pshah_manager/topcoder123

iversonLv commented 6 years ago

It’s done and ready for review

maxceem commented 6 years ago

@RishiRajSahu you asked for:

Design links URL should be aligned to the right and 30px from the widest text element design link name.

Do I get you right that you'd like all the links in both milestones to be aligned to the widest title +30px across both milestones? Note in such case I think the task would require using JavaScript to align links across two milestones.

RishiRajSahu commented 6 years ago

@maxceem Yes as per the requirement both milestones should have consistent alignment of links. Didn't got why it will need javascript for that ?

maxceem commented 6 years ago

@RishiRajSahu What I mean if these milestones have to be aligned between each other, see screenshot

align

While we can align links inside one milestone using CSS only, I think we cannot do that without JS to align links between two different milestones.

RishiRajSahu commented 6 years ago

@maxceem so there are few things which i have noted

They are two different components used at each places
Possible way to solve this is by either making two components as similar as possible using styling
Even after making them similar by using styling there will be an issue when title length is more
~We can use ellipses for long title name if length exceeds beyond the space~
It doesn't make sense to align when titles are longer, but if title names are within desired length we can make them align using some refactoring in div and styling.
If title lengths are longer we already have code in place for that - https://github.com/appirio-tech/connect-app/issues/2329#issuecomment-411776138

maxceem commented 6 years ago

@iversonLv There is a couple of edge cases left, please have a look https://github.com/appirio-tech/connect-app/pull/2486#pullrequestreview-154586156.

maxceem commented 6 years ago

@RishiRajSahu the issue is fixed as per requirements and PR is merged. The output looks like this fyi:

RishiRajSahu commented 6 years ago

@maxceem yeah looks good !