Open maxceem opened 4 years ago
I've checked these countries, and looks like the issue, is that they are not supported by the library we use https://www.npmjs.com/package/libphonenumber-js see metadata https://gitlab.com/catamphetamine/libphonenumber-js/-/blob/master/PhoneNumberMetadata.xml.
As we cannot edit the lib, I guess we can probably remove these items from the country list as these looks like some edge cases and in most cases user can just enter the phone number, but it would choose another place which shares the same phone code:
Antarctica
Bouvet Island
small island with nothingHeard Island and McDonald Islands
shares phone code with other islands of AustralliaPitcairn
shares phone code with New Zeland South Georgia and the South Sandwich island
looks like have the phone code +500 https://en.wikipedia.org/wiki/South_Georgia_and_the_South_Sandwich_Islands same as Falkland Islands (Malvinas)
https://en.wikipedia.org/wiki/Falkland_IslandsBelow are the details:
Antarctica
doesn't have its own phone code https://www.quora.com/Why-does-Antarctica-have-a-single-telephone-country-code-+672-even-though-it-is-not-a-sovereign-country
Bouvet Island
is a part of Norway https://en.wikipedia.org/wiki/Bouvet_Island and looks like don't have any phones at all.
Heard Island and McDonald Islands
is a part of Australia but it has its own phone code which it shares with other islands:
Pitcairn
shares phone code with New Zeland https://en.wikipedia.org/wiki/Pitcairn_Islands
South Georgia and the South Sandwich island
looks like have the phone code +500 https://en.wikipedia.org/wiki/South_Georgia_and_the_South_Sandwich_Islands same as Falkland Islands (Malvinas)
https://en.wikipedia.org/wiki/Falkland_Islands
@vikasrohit do you think we can remove these countries from the list? https://github.com/appirio-tech/connect-app/issues/3831#issuecomment-610390732
@maxceem Lets hold on this. Let me ask product manager.
@maxceem @vikasrohit - thanks for the great research. we can move forward with removing these countries from the list.
@vikasrohit on the second though, I think we have to get it in sync with list of countries at our backend.
If we remove these countries client-side but later backend returns to us some member with some the removed country, there could be an issue.
As I think this issues is not critical, I suggest postpone with removing and doing more research on the server side, so we close the question with countries completely.
Okay, we can delay it to next release. It is not a priority issue right now. And in fact we are going to get rid of Connect registration pages very soon after this release, I guess by mid of the May. So, we might not need to do countries changes there.
Follow up from issue https://github.com/appirio-tech/connect-app/issues/3823
There are few issues in the list, like Selecting some countries will select
US
from the list NOT the original country, Some country codes are incorrect, Some numbers are incorrect. I think we need to refine the list completely.https://www.screencast.com/t/5wOgFtTPIZMa
Antarctica
Bouvet Island
Heard Island and McDonald Islands
Pitcairn
South Georgia and the South Sandwich island