[$25] After applying the filter from the table column headers; it won't take effect when switching the tabs (Active, In Reiew etc...)

codejamtc commented 4 years ago

Expected behavior

Either filter should be reset, if not that filter should apply to the currently selected tab

Actual behavior

After applying the filter from the table column headers; it won't take effect when switching the tabs (Active, In Reiew etc...)

Steps to reproduce the problem

Login as Manager
Click All Projects > And apply 'TopConnCustomer' to Customer filter
Switch the tab to 'Active' (It worked sometimes)
Switch the tab to 'In Review' (Issue begins)
Switch the tab to 'Completed'

Check the Project Ref and Topcoder filter as well

Screenshot/screencast

https://monosnap.com/file/fUUOEnvgbipzE2WwiDf3qncCaUHSns

Environment

OS: Window 10
Browser (w/version): Chrome 80.0.3987.149 (Official Build) (64-bit)
User role (client, copilot or manager): Manager
Account used: TCConManager

vikasrohit commented 4 years ago

@maxceem I didn't understand this issue, did you get what exactly is the problem?

maxceem commented 4 years ago

Here is how I understand this issue:

we open All projects tab and filter projects by Customer
after that, we choose another tab, for example, projects Cancelled
in this tab we ignore filter by Customer and show all the projects filtered by project status. BUT at the same time we still have Customer filter field filled with our data:
So we have to make it consistent and apply one of two possiblee fixes:
1. When we change tab we have to clear table fitlers, because we don't respect them
2. OR we don't clear filters in table by Customers but we have to respect it, and still filter projects by Customers even when we switch tab

codejamtc commented 4 years ago

@maxceem You are correct, Sorry for that my bug report is not clear enough.

vikasrohit commented 4 years ago

Okay, understood @maxceem. I think for we can go with 1) option because if we want to keep the filters, we have to have some way to let user know that currently they are viewing filtered view which is not the case right now. We can do something similar to the Asset Library filtering. What do you suggest?

maxceem commented 4 years ago

@vikasrohit agree. With the current design we can only go with option 1).

We can do something similar to the Asset Library filtering. What do you suggest?

Maybe we can ask designers to come up with a good solution:

I think we cannot use directly the same approach as in Asses Library, as there is no good place for it. If we add such a text and button, it feels like it would be too much:
Probably we also need to improve the UI of tables with filter to have some indicators per column, that it has a filter applied.

vikasrohit commented 4 years ago

@maxceem we do have some designs changes for project listing page coming soon but that might be couple of release away. So, for now I guess, we can go with clearing the text in filter column when user switches the status filter. One thing I want to know is what happens right now when user comes to the original status filter where the column filter was applied, does it retain the data filtered there?

maxceem commented 4 years ago

One thing I want to know is what happens right now when user comes to the original status filter where the column filter was applied, does it retain the data filtered there?

No, it doesn't.

maxceem commented 4 years ago

Sum up:

when we choose another tab:

we should clear all filters we have in the table columns, as we don't respect them anyway:

maxceem commented 4 years ago

This issue is open for pickup.

srjr19 commented 4 years ago

@bug-bash-helper assign

bug-bash-hunt-helper[bot] commented 4 years ago

@simranb86 ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

srjr19 commented 4 years ago

@bug-bash-helper taking some time to understand the flow of code, give me like 5-6 hrs more to create PR.

bug-bash-hunt-helper[bot] commented 4 years ago

Hi @simranb86.

assign

To assign yourself to the issue make a comment:

@bug-bash-helper assign me

unassign

To unassign yourself from the issue make a comment:

@bug-bash-helper unassign me

ready for review

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

abdullatku commented 4 years ago

@maxceem can I take this?

srjr19 commented 4 years ago

@abdullatku still working on it, I will open in next 4 hrs if not done.

nahidshahin commented 4 years ago

@maxceem it's more than 21hrs, can you open it for pickup please?

srjr19 commented 4 years ago

@bug-bash-helper need an hour more, plz feel free to open if no PR in next an hour.

bug-bash-hunt-helper[bot] commented 4 years ago

Hi @simranb86.

assign

To assign yourself to the issue make a comment:

@bug-bash-helper assign me

unassign

To unassign yourself from the issue make a comment:

@bug-bash-helper unassign me

ready for review

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

bug-bash-hunt-helper[bot] commented 4 years ago

@simranb86 ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

srjr19 commented 4 years ago

@bug-bash-helper https://github.com/appirio-tech/connect-app/pull/3928 is ready for review

bug-bash-hunt-helper[bot] commented 4 years ago

@simranb86 ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

maxceem commented 4 years ago

@simranb86 the review is ready, please have a look https://github.com/appirio-tech/connect-app/pull/3928#pullrequestreview-395989584

abdullatku commented 4 years ago

@maxceem can I take this challenge?

maxceem commented 4 years ago

@abdullatku no, this issue is not open for pick up. The current participant can apply fixes.

srjr19 commented 4 years ago

@bug-bash-helper #3928 is ready for review

bug-bash-hunt-helper[bot] commented 4 years ago

@simranb86 ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

maxceem commented 4 years ago

@simranb86 issue is not fixed, please have look at review https://github.com/appirio-tech/connect-app/pull/3928#pullrequestreview-396161935

srjr19 commented 4 years ago

@simranb86 issue is not fixed, please have look at review #3928 (review)

@maxceem checking, I was testing with project name filtering mostly - let me check with all fields

srjr19 commented 4 years ago

@bug-bash-helper unassign me - couldn't trace why it would fail for that sort filter as discussed over slack so opening this.

bug-bash-hunt-helper[bot] commented 4 years ago

@simranb86 ✅ you have been unassigned from this issue.

Now you may pick up another issue which is open for pickup if you like to.

maxceem commented 4 years ago

Here is the discussion from Slack, for everyone:

simranb86:

i think my earlier fix was right but it fails to send backend calls, due to sort making the URL as %20D which backend accepts to be + but not able to trace where we do this conversion. Could you help understand the flow a bit ? where this encode/decode is done for sort. (edited) Failing URL https://api.topcoder-dev.com/v5/projects/?fields=id,name,description,members,invites,status,type,actualPrice,estimatedPrice,createdAt,updatedAt,createdBy,updatedBy,details,lastActivityAt,lastActivityUserId,version,templateId&sort=updatedAt%2Bdesc&perPage=20&page=1&status=completed Passing URL https://api.topcoder-dev.com/v5/projects/?fields=id,name,description,members,invites,status,type,actualPrice,estimatedPrice,createdAt,updatedAt,createdBy,updatedBy,details,lastActivityAt,lastActivityUserId,version,templateId&sort=updatedAt+desc&perPage=20&page=1&status=completed The only diff is + in field sort. I think backend should be strong to understand this encoding also ? I am trying to lookup code where this encode/decode is done in front-end but don’t see any logic

maxceem: the thing is that we we have to send to the server updatedAt desc with a space. Space can be encoded in URL via +. So in URL we send it as updatedAt+desc. The alternative way of encoding space is %20. So we may also send it as updated%20desc and URL https://api.topcoder-dev.com/v5/projects/?fields=id,name,description,members,invites,status,type,actualPrice,estimatedPrice,createdAt,updatedAt,createdBy,updatedBy,details,lastActivityAt,lastActivityUserId,version,templateId&sort=lastActivityAt%20desc&perPage=20&page=1&status=reviewed works. (edited)

URL with %2B is incorrect, because there are 2 encodings:

first ` space is replaced with+`
and after + is encoded as %2B So instead of sending space to the server, the URL sends +, and server doesn’t accept it.

maxceem commented 4 years ago

This issue is now open for pickup.

Vips19 commented 4 years ago

@bug-bash-helper assign

bug-bash-hunt-helper[bot] commented 4 years ago

@Vips19 ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

Vips19 commented 4 years ago

@bug-bash-helper unassign

bug-bash-hunt-helper[bot] commented 4 years ago

@Vips19 ✅ you have been unassigned from this issue.

Now you may pick up another issue which is open for pickup if you like to.

nahidshahin commented 4 years ago

@bug-bash-helper assign

bug-bash-hunt-helper[bot] commented 4 years ago

@nahidshahin ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

nahidshahin commented 4 years ago

@bug-bash-helper https://github.com/appirio-tech/connect-app/pull/3940 is ready for review

bug-bash-hunt-helper[bot] commented 4 years ago

@nahidshahin ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

maxceem commented 4 years ago

@nahidshahin review is ready, please, have a look https://github.com/appirio-tech/connect-app/pull/3940#pullrequestreview-396756930

nahidshahin commented 4 years ago

@maxceem feedback are addressed , please check again. Thanks

maxceem commented 4 years ago

@nahidshahin the new review is ready, please have a look https://github.com/appirio-tech/connect-app/pull/3940#pullrequestreview-397097484

nahidshahin commented 4 years ago

@bug-bash-helper unassign me

bug-bash-hunt-helper[bot] commented 4 years ago

@nahidshahin ✅ you have been unassigned from this issue.

Now you may pick up another issue which is open for pickup if you like to.

abdullatku commented 4 years ago

@bug-bash-helper assign

bug-bash-hunt-helper[bot] commented 4 years ago

@abdullatku ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

abdullatku commented 4 years ago

@bug-bash-helper #3952 is ready for review

bug-bash-hunt-helper[bot] commented 4 years ago

@abdullatku ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

maxceem commented 4 years ago

@abdullatku review is ready, please have a look https://github.com/appirio-tech/connect-app/pull/3952#pullrequestreview-398263734

appirio-tech / connect-app