Assets Library > Links: Can enter invalid URLs - Githubissues

appirio-tech / connect-app

Build your next project on Connect with the power of crowdsourcing

https://connect.topcoder.com

44 stars 139 forks source link

Assets Library > Links: Can enter invalid URLs #3855

Open codejamtc opened 4 years ago

codejamtc commented 4 years ago

Expected behavior

Should validate the correct URL regex format. https://regexr.com/37i6s

Actual behavior

Assets Library > Links: Can enter invalid URLs

Steps to reproduce the problem

Login as Manager
Click on a project > Assets Library {https://connect.topcoder-dev.com/projects/9057/assets}
Select Links > Add New
Enter Name=ABC; URL=www.google.asdasd.sadsad.sadasd..www.google.lk
Click Add Link (Use https://www.w3schools.com/php/phptryit.asp?filename=tryphp_func_validate_url)

Screenshot/screencast

Environment

OS: Window 10
Browser (w/version): Chrome 80.0.3987.149 (Official Build) (64-bit)
User role (client, copilot or manager): Manager
Account used: TCConManager

vikasrohit commented 4 years ago

I don't think we need this kind of validation. It neither blocks any one to use the functionality nor it causes any errors. It is upto the user what he/she wants to share. We have few standard URL validations in place, but we don't want to make it unnecessary strict which may cause some issue with valid URLs as well. Still keeping this in backlog, if we need it some day.