Closed fnisen closed 8 years ago
Yep, not working.
I'll add make "My projects only" clickable to active the respective checkbox.
@mahestro don't understand your comment. What do you mean?
Clicking this text should activate the checkbox http://take.ms/ZnWi9
Challenge live, merged with #42 https://www.topcoder.com/direct/contest/detail.action?projectId=30055194
Thanks.. also can you make that checkbox active by default.
@mahestro got it, yes good call.
@parthshah I wouldn't make it active by default. User may not realize that it's on and miss information. I would show more and let them filter.
I mostly care about projects that I am a part of and every once in awhile go exploring for all projects. Pretty soon we should be broadcasting / notifying interested parties copilots & managers of new projects (recently activated , or created).
Not necessarily--if you're a manager or copilot, you care about all projects, so that you can screen new ones. Anyway, the option should be persistent--so we start out with it not selected by default, so that the user knows what information is available. After that, they can switch it on and it stays. To me it's more important that they know the data is there and try to figure out how to filter, rather than not realizing they're seeing filtered data.
BTW, the main reason why it's not behaving properly is because the data is hardcoded, not pulled from API yet.
For this task I focused in cleaning the search component, fixing a couple of bugs it had and preparing it for the transformation for the new nav. If we want to address the data binding we'd need to create another issue.
@mahestro seems like it was updated, but is not behaving properly. This is all I'm seeing:
@fnisen typeahead is using hardcoded check as of now. It returns all challenges that have 'LUX' in their name. We don't have API ready for this. So, I guess for now we should disabled the typeahead.
It shouldn't have that "popular" on top. Can you try reinstalling the modules in your local environment? Or if this in prod, needs nodules reinstallation, since the react-components#feature/connectv2 was updated.
Just checked online and it's looking as expected :) @vikasrohit did the magic with the modules, I guess. Thanks.
@mahestro I would not mind the credit, however, I haven't done any magic there. Might be the latest build deployed on dev did the trick. 😬
@mahestro can you please take out the hardcoded results? It makes it seem broken. If we can't have the typeahead by launch, that's OK.
Yes, for demo purposes it's not good. I'll take it out.
Done. Deleted the demo projects and added a TODO.
I think this was planned, but is not working. If we can't have it for this release, that's OK.