Update Challenge Service

[kbowerma]

There are several areas which need to be updated in the API

• Add prizes to the ChallengeResource
• Add Requirements endpoints and resources

Requirement
- id
- text
- challengeId

• Remove requirement data from scorecarditem resource
• Have Scorecard Item reference the requirementId
• Add account and accountId to Challenge. both strings
• for the status enum - change ACTIVE to SUBMISSION

[indytechcook]

@gaitonde @kbowerma I"m going to launch a challenge tomorrow to iterate on the challenge service. Please take a look and let me know if you want to add anything.

[gaitonde]

Much like scorecards, participants, etc. I think the requirements should hang off the challenge - eg.

GET /challenges/{challengeId}/requirements - get all requirements PUT /challenges/{challengeId}/requirements/{requirementId} - update a requirement DELETE /challenges/{challengeId}/requirements - delete a requirement etc.

Ie. I wouldn't do this style (w/ challengeId as an attribute) - GET /requirements - get all requirements PUT /requirements/{requirementId} - update a requirement DELETE /requirements - delete a requirement

[kbowerma]

I have no recollection of creating this bug.

[gaitonde]

I thought it was odd that you created it. I thought it would be neil since I mentioned these items to him. github bug?

[indytechcook]

@gaitonde that was my plan.

@kbowerma this original was the one you logged about the prizes not being on the challenge. I hijacked and expanded!

[gaitonde]

@indytechcook - do we currently have anything in the model to support the "results" of a challenge - ie. who won and what place?

[indytechcook]

We have the resource defined: https://github.com/appirio-tech/lc1-challenge-service/blob/master/api/swagger/swagger.yaml#L1166

but no endpoints, controllers or models. We hadn't decided exactly the data model yet.

On Wed, Oct 22, 2014 at 11:14 AM, Dayal Gaitonde notifications@github.com wrote:

@indytechcook https://github.com/indytechcook - do we currently have anything in the model to support the "results" of a challenge - ie. who won and what place?

— Reply to this email directly or view it on GitHub https://github.com/topcoderinc/serenity-core/issues/170#issuecomment-60101028 .

[gaitonde]

Ok thanks. Created an issue to track #173

[indytechcook]

Should I move forward with what we have for this issue then we can do a follow up challenge for the resutls?

On Wed, Oct 22, 2014 at 11:29 AM, Dayal Gaitonde notifications@github.com wrote:

Ok thanks. Created an issue to track #173 https://github.com/topcoderinc/serenity-core/issues/173

— Reply to this email directly or view it on GitHub https://github.com/topcoderinc/serenity-core/issues/170#issuecomment-60103589 .

[gaitonde]

yes

[indytechcook]

@gaitonde and @kbowerma can you review the updated swagger?

https://github.com/appirio-tech/lc1-challenge-service/blob/challenge-updates/api/swagger/swagger.yaml

It's on the challenge-updates branch.

[gaitonde]

Will look at more later, but some quick feedback -

1. Shouldn't "id" be required on ChallengeResource? Right now I only see title.
2. Also can we add these 2 attributes for the ChallengeResource
   • source (will be loudercrowd/topcoder (or lc/tc))
   • sourceId (id from the source system; for lc can be null or same as id on challengeresource)

This will set us up for bringing over challenges from tc.

[indytechcook]

. Shouldn't "id" be required on ChallengeResource? Right now I only see title.

The same resource is used on the POST where we won't have an id.

Also can we add these 2 attributes for the ChallengeResource

Sure.

[indytechcook]

Swagger file has been updated

[indytechcook]

Challenge Launched:

https://www.topcoder.com/direct/contest/detail.action?projectId=30046668 http://www.topcoder.com/challenge-details/30046668/?type=develop&noncache=true

[gaitonde]

@indytechcook source and sourceId are supposed to be on ChallengeResource. On the challenge-updates branch they are on RequirementResource.

[indytechcook]

There is a submission. I'll have it merged in today so I'm keeping on this sprint.

[indytechcook]

The challenge didn't complete successfully. It's still running

[indytechcook]

@kbowerma and @gaitonde These updates are looking good now and have been pushed to heroku