appirio-tech / lc1-project

Core challenge engine for Serenity Project
MIT License
6 stars 8 forks source link

File Upload and Download changes for www site #439

Closed indytechcook closed 9 years ago

indytechcook commented 9 years ago

Follow ups:

indytechcook commented 9 years ago

Upload link works now but S3 isn't configured correctly.

indytechcook commented 9 years ago

I had a bunch of issues with uploading the directly from the browser to S3. The issue is with the headers of the request to get the URL must match the headers to PUT the file.

I've kept the directive and service to upload the file on the www site but they aren't being used:

Follow up issue #446 logged.

To implement the new downloading of files:

Remove the public header when uploading the file: https://github.com/appirio-tech/lc1-external-challenge-service/blob/master/controllers/challenges.js#L306

cc @gaitonde