search

appirio-tech / lc1-project

Core challenge engine for Serenity Project
MIT License
6 stars 8 forks source link

Config: Standardize Enabling Auth Config #464

Closed gaitonde closed 9 years ago

gaitonde commented 9 years ago

We have 3 different env vars for enabling/disabling auth right now -

All Heroku Apps that authorize requests should be updated to have an auth environment variable. That variable name should be AUTH_ENABLED. The value should be true for all apps except dev-*

App code default should attempt to read this environment vars, be set to true and overrides should be done via .env file.

gaitonde commented 9 years ago

@indytechcook - i fixed this in the challenge app. Any issues if I update the custom-environment-variables.yaml the Challenge Service and Discussion Service?

TC_AUTH_ENABLED => AUTH_ENABLED

I'll also update the envs.

indytechcook commented 9 years ago

Have at it. Just don't break everything :)

On Wed, Dec 17, 2014 at 8:14 AM, Dayal Gaitonde notifications@github.com wrote:

@indytechcook https://github.com/indytechcook - i fixed this in the challenge app. Any issues if I update the custom-environment-variables.yaml the Challenge Service and Discussion Service?

TC_AUTH_ENABLED => AUTH_ENABLED

I'll also update the envs.

— Reply to this email directly or view it on GitHub https://github.com/appirio-tech/lc1-project/issues/464#issuecomment-67320063 .

indytechcook commented 9 years ago

Discussion and Challenge services have been updated in dev