search

appirio-tech / lc1-project

Core challenge engine for Serenity Project
MIT License
6 stars 8 forks source link

Scorecard link should not show up unless scorecard exists #519

Closed gaitonde closed 9 years ago

gaitonde commented 9 years ago

Link needs to point to:

:louderCrowdBaseUrl/scorecard/challenges/:challengeId/scorecards/:scorecardId

indytechcook commented 9 years ago

This is where it goes if there is an existing scorecard. A scorecard doesn't exist until after someone manually creates the scorecard. The real change is that the link should not show up unless a scorecard has been submitted.

gaitonde commented 9 years ago

Agreed on the vis part, but I made a change last week and the link is actually different so the page on www needs to be updated.

indytechcook commented 9 years ago

@gaitonde can you confirm this is a properly formatted url? http://dev.lc.topcoder.com/scorecard/challenges/13/scorecards/16

indytechcook commented 9 years ago

Pushed to dev. Code is on master of www

gaitonde commented 9 years ago

@indytechcook - that is the proper format, but note that code is only on the release branch and has not been pushed to dev. We should do our merge down to dev today.