search

appirio-tech / tc-core-library-js

6 stars 9 forks source link

401 vs 403 #13

Open cwdcwd opened 6 years ago

cwdcwd commented 6 years ago

There's a couple issues with this line and this line:

  1. the 403 should be const and not a magic number
  2. 403 is reserved for when a user is denied authorization, despite having a valid authentication. 401 is for when authentication is invalid. Good explanation can be read here
BadalZ commented 6 years ago

No more relevant and so closing it out

cwdcwd commented 6 years ago

@BadalZ why isn't this relevant any more?

sharathkumaranbu commented 5 years ago

@sachin-maheshwari Are we planning to fix this issue or not?

sharathkumaranbu commented 5 years ago

@sachin-maheshwari Could we address this as well in the upcoming release? This create lot of inconsistencies in Swagger response vs actual API response

cc @cwdcwd

cwdcwd commented 5 years ago

@sachin-maheshwari did we happen to fix this one at all?