appitysnacks / shoot-ios

Shoot Contact Sharing iOS
0 stars 0 forks source link

Ability to add multiple Company Names and Titles #1

Open appitysnacks opened 7 years ago

appitysnacks commented 7 years ago

Currently the user is limited to having only one Company Name field and one Title field. I;d like to change this so that a user can add multiple Company Names and Titles just like they can add multiple phone numbers, email addresses etc.

This screen is from the android version that already has this functionality implemented.

shoot_androidexample 1

thattyson commented 7 years ago

@appitysnacks is this the layout you were expecting for the profile view (left)? Company and job title being on separate lines?

Also, when exporting the vCard to email how would you like me to format? I'm assuming a user will only select a single company/job title but what if they select multiple?

group

appitysnacks commented 7 years ago

Re layout: yes this is correct, as you have it, with one line for each company/title entry

Re vCard export: I would assume that they would select one of each yes....

BUT, from what I understood about vCards, it only accepts (accommodates) one name/title (IF this is the case should there be a message that tells the user to pick only one of each?

thattyson commented 7 years ago

@appitysnacks I can see two solutions:

  1. Only ever allow a user to select a single job title/company when creating a profile; showing an error if they hit "save" with multiple selected.
  2. Allow them to select multiple but show a warning saying "You've selected multiple <Companies or Job Titles (or both)>. These will be shown as 'Architect / Marine Biologist' and 'Vandelay / Company 2' when exported." This way they can have multiple selected but they'll export as a single item.

I think I'd prefer #2 if I were a user.

appitysnacks commented 7 years ago

Thanks Tyson. Geat, yes agreed #2 - can we just swap in 'shared' for 'exported'?

Question: Does this message appear when user taps to 'Shoot' that profile?

thattyson commented 7 years ago

I'd assume the message would appear when they tap "Save" on the edit screen

appitysnacks commented 7 years ago

ok thanks.

thattyson commented 7 years ago

Need to match Android naming conventions:

image1