search

appium-boneyard / appium-plugins

Officially-maintained plugins for the Appium server
Apache License 2.0
32 stars 7 forks source link

fix!: convert newMethodMap and updateServer to static properties #6

Closed jlipps closed 3 years ago

jlipps commented 3 years ago

This follows the new pattern that will be established in Appium. It makes sense for these to be static properties since they are things the plugin does one time on server start.

jlipps commented 3 years ago

(CI will fail till we get https://github.com/appium/appium/pull/15128 merged and published, since these are mutually dependent)

jlipps commented 3 years ago

ok will publish and test in appium/appium, then when that's published, re-test in this repo to ensure everything works.

jlipps commented 3 years ago

all plugins published, including fake-plugin at 1.0.0

jlipps commented 3 years ago

when i pushed the latest appium, CI went green again: https://github.com/appium/appium-plugins/actions/runs/594132550