appium-boneyard / appium-selendroid-driver

Appium's Selendroid integration
Apache License 2.0
9 stars 16 forks source link

Cachable, proxy-friendly selendroid jar download. #36

Closed jgreen210 closed 8 years ago

jgreen210 commented 8 years ago
jgreen210 commented 8 years ago

Fixes https://github.com/appium/appium-selendroid-driver/issues/24 and also allows me to cache the download with an HTTP proxy.

jgreen210 commented 8 years ago

This travis build failed when installing appium-selendroid-driver:

https://travis-ci.org/appium/appium-selendroid-driver/jobs/158700317 https://s3.amazonaws.com/archive.travis-ci.org/jobs/158700317/log.txt

...saying:

Error: bad SHA256 fingerprint: 7cbc32cb03411d9714878cb390f1f93ecb9ec76f11341c47827c00dfa7a06c42

It then tries to run the unit tests anyway, which fail since there's no apk or manifest.

When I download the jar locally, I still get the checked-in fingerprints:

$ curl --silent --location https://github.com/selendroid/selendroid/releases/download/0.17.0/selendroid-standalone-0.17.0-with-dependencies.jar | md5sum -
5e1f7de5e4d2eb77b68675d76c5edf6a  -
$ curl --silent --location https://github.com/selendroid/selendroid/releases/download/0.17.0/selendroid-standalone-0.17.0-with-dependencies.jar | shasum --algorithm 256 -
7cf7163ac47f1c46eff95b62f78b58c1dabdec534acc6632da3784739f6e9d82  -
$ curl --silent http://repo1.maven.org/maven2/io/selendroid/selendroid-standalone/0.17.0/selendroid-standalone-0.17.0-with-dependencies.jar | shasum --algorithm 256
7cf7163ac47f1c46eff95b62f78b58c1dabdec534acc6632da3784739f6e9d82  -
imurchie commented 8 years ago

Is this error something to do with Node 6? It seems to work fine in 4 and 5.

jgreen210 commented 8 years ago

Tested locally with node 5.4.1 before submitting, but not 6.2.1, which breaks. This is fixed by using Buffer not String to hold body: 27569b2.

imurchie commented 8 years ago

That would be why we test against multiple versions!

imurchie commented 8 years ago

Thanks for this! It's awesome!

One thing: can you squash into a single commit? Then we can get it in.

jgreen210 commented 8 years ago

It's now squashed to one commit.

imurchie commented 8 years ago

Awesome! Thank you very much for this.

imurchie commented 8 years ago

Published as appium-selendroid-driver@1.4.3.