search

appium-boneyard / appium-selendroid-driver

Appium's Selendroid integration
Apache License 2.0
9 stars 16 forks source link

Update network connection state change in Selendroid driver #45

Closed mykola-mokhnach closed 7 years ago

mykola-mokhnach commented 7 years ago

Fixes the same problem as in https://github.com/appium/appium-uiautomator2-driver/pull/68

jlipps commented 7 years ago

@mykola-mokhnach you're the maintainer of this project now, so merge at will :-)

mykola-mokhnach commented 7 years ago

@jlipps should I also increase component version number every time I merge something new?

mykola-mokhnach commented 7 years ago
screen
imurchie commented 7 years ago

@mykola-mokhnach Do you mean in package.json? Then no. That gets updated through publishing.

The process is:

  1. merge PR
  2. Pull master locally
  3. npm version [major|minor|patch] (which one depends on what sort of changes they are)
  4. git push --tags origin master
  5. npm publish

Step 3 will update the package.json version number and create a tag in git.

mykola-mokhnach commented 7 years ago

How can I merge to master if I don't have write access to the repository?

imurchie commented 7 years ago

Do you not? I thought that's what @jlipps was talking about.

jlipps commented 7 years ago

ok @mykola-mokhnach i gave you owner rights over the whole appium org. use this awesome power with care :-)

mykola-mokhnach commented 7 years ago

hqdefault

jlipps commented 7 years ago

also, I always add a step in between isaac's (2) and (3):

2b: rm -rf node_modules && npm install, and rerun unit tests

just as a safety mechanism before publishing, to ensure that i'm getting all the latest deps that a new install would get.